Conversation
Cover key behaviours of the HTML table type-inference helpers: - inferListType: empty/whitespace/ → Null; int, decimal, float (scientific), bool, string; NaN/NA as float (or Null with preferOptionals); DateOnly/DateTime for ISO date strings; mixing int+decimal widened to decimal; int+scientific widened to float; int+string produces Heterogeneous; NaN+int with preferOptionals=false widened to float - inferHeaders: ≤2 rows → false; header-vs-data type mismatch → true with header names; uniform-type rows → false; data type returned Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dsyme
deleted the
repo-assist/test-htmlinference-2026-04-23-d7c00d2a236baee0
branch
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist, an AI assistant for this repository.
Adds a new test file
tests/FSharp.Data.Core.Tests/HtmlInference.fswith 23 unit tests covering theHtmlInference.inferListTypeandHtmlInference.inferHeadersinternal functions, which had no dedicated test coverage.What's covered
inferListTypeNull\t,"") →Null / →Null(HTML non-breaking space treated as missing)intdecimal(e.g."1.5")float(e.g."1e100")boolstringdecimalfloatHeterogeneousNaN/NAwithpreferOptionals=false→float(explicit missing = float)NaNwithpreferOptionals=true→Null"2023-01-01") →DateTimeorDateOnly(runtime-dependent)preferOptionals=false→ widens tofloatintinferHeaders(false, None, None, None)(false, None, None, None)(false, None, None, None)(not enough info)(true, Some headers, ...)(false, None, None, None)Test Status
dotnet test tests/FSharp.Data.Core.Tests/ --filter "HtmlInference"— 23 passed, 0 faileddotnet test tests/FSharp.Data.Core.Tests/— 2980 passed, 0 failed